fix(core): projectName should not be interpolated as undefined #23145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b670d6a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
requested changes
May 2, 2024
packages/nx/src/project-graph/utils/project-configuration-utils.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/project-graph/utils/project-configuration-utils.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/project-graph/utils/project-configuration-utils.ts
Outdated
Show resolved
Hide resolved
AgentEnder
force-pushed
the
fix/projectNameToken
branch
2 times, most recently
from
572e86b
to
0c3477b
Compare
FrozenPandaz
requested changes
May 2, 2024
| ) { | ||
| throw new ProjectWithConflictingRootsError(project.name, project.root); | ||
| } | ||
| console.log(project, knownProjects); |
AgentEnder
force-pushed
the
fix/projectNameToken
branch
from
0c3477b
to
06ab832
Compare
AgentEnder
force-pushed
the
fix/projectNameToken
branch
from
06ab832
to
b670d6a
Compare
FrozenPandaz
approved these changes
May 2, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Tokens are interpolated into arguments while merging things into the root map. Unfortunately, this means
{projectName}is sometimes interpolated asundefinedbecause the project's name isn't known yet.Expected Behavior
Tokens are interpolated after the root map has been constructed, but still during
createProjectConfigurationss.t. we can know that we have final project configurations afterwards.Related Issue(s)
Fixes #