fix(testing): convert-to-inferred generators should add includes only when needed #23159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d83f3e9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
fix-convert-to-inferred-bugs
branch
from
93fe2b0
to
0f7e21c
Compare
…all config files are handled
Coly010
force-pushed
the
fix-convert-to-inferred-bugs
branch
from
0f7e21c
to
d83f3e9
Compare
JamesHenry
approved these changes
May 3, 2024
FrozenPandaz
approved these changes
May 3, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
includesare being added to all new plugins that are being added to nx.json.It should only be added when not all config files are addressed by the plugin to be added.
Cypress Convert To Inferred is not creating a
ciWebServerCommandwhen it is possible to do so.Expected Behavior
Ensure
includesis added only when required.Ensure
cypress:convert-to-inferredis adding a ciWebServerCommand correctlyRelated Issue(s)
Fixes #