Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): pin testing-library/jest-dom to compatible version #23161

Merged
merged 1 commit into from
May 3, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 3, 2024

Current Behavior

@testing-library/jest-dom released a version that is broken currently and it was being found by our version string.

Expected Behavior

Pin the version of the package to the latest working versions

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner May 3, 2024 10:25
@Coly010 Coly010 requested a review from mandarini May 3, 2024 10:25
@Coly010 Coly010 self-assigned this May 3, 2024
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 10:28am

@Coly010 Coly010 merged commit dc54b55 into master May 3, 2024
6 checks passed
@Coly010 Coly010 deleted the fix-remix-testing branch May 3, 2024 12:03
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants