fix(misc): make generated ci workflow work without nx-cloud #23199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0cb5e70. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
fix/workflows
branch
from
511599f
to
0cb5e70
Compare
AgentEnder
approved these changes
May 6, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
ci-workflowgenerators error if Nx Cloud has not been enabled.With the new Github onboarding flow, there is a chicken or the egg problem.
The Github onboarding flow creates a PR but we don't have a pipeline to run against it. To create the pipeline, Nx Cloud has to be enabled... which... creates a lackluster PR.
Expected Behavior
ci-workflowgenerators do not error if Nx Cloud has not been enabled. This way, theci-workflowgenerator will be able to create a workflow, which the PR made by Nx Cloud's Github onboarding flow will be run against.Related Issue(s)
Fixes #