Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): properly indent command output with mixed line endings #23321

Merged

Conversation

Den-dp
Copy link
Contributor

@Den-dp Den-dp commented May 11, 2024

Current Behavior

The command output is not indented when it has mixed line endings (crlf and lf)

image

Expected Behavior

image

Related Issue(s)

@Den-dp Den-dp requested a review from a team as a code owner May 11, 2024 15:17
@Den-dp Den-dp requested a review from AgentEnder May 11, 2024 15:17
Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 3:19pm

@AgentEnder AgentEnder merged commit b5d4775 into nrwl:master May 13, 2024
6 checks passed
@Den-dp Den-dp deleted the fix/indent-output-with-mixed-line-endings branch May 14, 2024 10:47
FrozenPandaz pushed a commit that referenced this pull request May 14, 2024
…3321)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
The command output is not indented when it has mixed line endings
(`crlf` and `lf`)

![image](https://github.com/nrwl/nx/assets/1770529/5f65e9c4-ded2-4fba-a6c8-9f22297b2b35)

## Expected Behavior

![image](https://github.com/nrwl/nx/assets/1770529/c8111456-407e-47af-8129-4efa6f5792ca)

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

(cherry picked from commit b5d4775)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants