Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): workspace remove generator should handle no root jest config #23328

Merged
merged 1 commit into from
May 13, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 13, 2024

Current Behavior

The @nx/workspace:remove generator will throw if there is not a jest.config.ts at the root of the workspace.
However, when using vitest for projects, there may not be a root jest.config file.

Expected Behavior

Handle no root jest.config file

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner May 13, 2024 10:10
@Coly010 Coly010 requested a review from xiongemi May 13, 2024 10:10
@Coly010 Coly010 self-assigned this May 13, 2024
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 10:12am

@JamesHenry JamesHenry merged commit 4f31608 into master May 13, 2024
6 checks passed
@JamesHenry JamesHenry deleted the fix-remove-generator branch May 13, 2024 12:34
FrozenPandaz pushed a commit that referenced this pull request May 13, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants