Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): throw a specific error for print-affected and affected graph #23336

Merged
merged 1 commit into from
May 13, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

A non-descriptive error is thrown when using the recently removed print-affected and affected:graph commands.

Expected Behavior

A descriptive error is thrown when using the recently removed print-affected and affected:graph commands.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from a team as code owners May 13, 2024 14:15
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 2:44pm

@FrozenPandaz FrozenPandaz merged commit 6f197e9 into master May 13, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the print-affected-err branch May 13, 2024 16:04
FrozenPandaz added a commit that referenced this pull request May 13, 2024
…ph (#23336)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

A non-descriptive error is thrown when using the recently removed
`print-affected` and `affected:graph` commands.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

A descriptive error is thrown when using the recently removed
`print-affected` and `affected:graph` commands.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 6f197e9)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants