fix(core): copy native files to tmp file location instead of .nx/cache #23375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6c0038c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
MaxKless
force-pushed
the
native-file-cache-tmp-folder
branch
from
3cc72a9
to
6c0038c
Compare
JamesHenry
approved these changes
May 15, 2024
FrozenPandaz
requested changes
May 15, 2024
| export const nativeFileCacheLocation = join( | ||
| tmpdir(), | ||
| 'nx-native-file-cache', | ||
| createHash('sha256').update(workspaceRoot).digest('hex') |
There was a problem hiding this comment.
Why do we need this nesting at all? Can't it be join(tmpdir(), 'nx/bin')?
There was a problem hiding this comment.
I want to keep the same behaviour as before where the files are workspace-scoped. I'm not sure if there could be funky side-effects when one repo calls nx reset and deletes the .node file that is currently used by another process in another workspace.
FrozenPandaz
approved these changes
May 15, 2024
| export const nativeFileCacheLocation = join( | ||
| tmpdir(), | ||
| 'nx-native-file-cache', | ||
| createHash('sha256').update(workspaceRoot).digest('hex') |
FrozenPandaz
pushed a commit
that referenced
this pull request
May 15, 2024
#23375) ## Current Behavior Currently, the `.node` files required to load native code are saved in `.nx/cache`. This can cause different issues: - users on windows sometimes experience errors during `nx reset` because it's trying to delete the entire folder and some process is still locking the file - `@angular-eslint` users are seeing the `.nx/cache` folder in their workspace since it uses `@nx/devkit` ## Expected Behavior We want no errors and for noone to be bothered by the `.node` file. This is why we move the `.node` file to a tmp location outside the workspace instead of `.nx/cache`. We still make sure to delete it during `nx reset` but throw no errors if that fails. It will simply be deleted by the next invocation of `nx reset`. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23224 (cherry picked from commit 5ce5337)
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, the
.nodefiles required to load native code are saved in.nx/cache. This can cause different issues:nx resetbecause it's trying to delete the entire folder and some process is still locking the file@angular-eslintusers are seeing the.nx/cachefolder in their workspace since it uses@nx/devkitExpected Behavior
We want no errors and for noone to be bothered by the
.nodefile. This is why we move the.nodefile to a tmp location outside the workspace instead of.nx/cache. We still make sure to delete it duringnx resetbut throw no errors if that fails. It will simply be deleted by the next invocation ofnx reset.Related Issue(s)
Fixes #23224