fix(core): only check for err
in handleWorkspaceChanges
#23500
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When there are watch event changes, and we filter them all out, we get an empty
changedEvents
array. There were previous checks that had a!changedEvents.length
condition that resolved to true when the length was 0.Expected Behavior
We now check to see if
err
is set before triggering the error branchRelated Issue(s)
Fixes #23031