fix(core): only check for err in handleWorkspaceChanges
#23500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c670664. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
approved these changes
May 17, 2024
AgentEnder
approved these changes
May 17, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 21, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> When there are watch event changes, and we filter them all out, we get an empty `changedEvents` array. There were previous checks that had a `!changedEvents.length` condition that resolved to true when the length was 0. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> We now check to see if `err` is set before triggering the error branch ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23031 (cherry picked from commit 3bbc964)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When there are watch event changes, and we filter them all out, we get an empty
changedEventsarray. There were previous checks that had a!changedEvents.lengthcondition that resolved to true when the length was 0.Expected Behavior
We now check to see if
erris set before triggering the error branchRelated Issue(s)
Fixes #23031