-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix(webpack): fixing null pointer about projectGraph with nx enhance configuration #26430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): fixing null pointer about projectGraph with nx enhance configuration #26430
Conversation
…configuration closed nrwl#26303
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 42aa827. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
2caa978
to
489b864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…configuration (#26430) Hello! I fixing issue related to nx project with enhanced webpack config. I created this repository to reproduce the bug: https://github.com/NicolasBelliard/nx-enhance-example ## Current Behavior When created an Nx repository with nx enhanced config, we faced the current issue when we try to build the application. ``` > nx run nx-enhance:build > webpack-cli build --node-env=production [webpack-cli] TypeError: Cannot read properties of undefined (reading 'nodes') at calculateProjectDependencies (/home/test/dev/nx-enhance/node_modules/@nx/js/src/utils/buildable-libs-utils.js:24:30) at calculateProjectBuildableDependencies (/home/test/dev/nx-enhance/node_modules/@nx/js/src/utils/buildable-libs-utils.js:20:12) at NxTsconfigPathsWebpackPlugin.handleBuildLibsFromSource (/home/test/dev/nx-enhance/node_modules/@nx/webpack/src/plugins/nx-typescript-webpack-plugin/nx-tsconfig-paths-webpack-plugin.js:37:111) at NxTsconfigPathsWebpackPlugin.apply (/home/test/dev/nx-enhance/node_modules/@nx/webpack/src/plugins/nx-typescript-webpack-plugin/nx-tsconfig-paths-webpack-plugin.js:17:14) at createCompiler (/home/test/dev/nx-enhance/node_modules/webpack/lib/webpack.js:78:12) at create (/home/test/dev/nx-enhance/node_modules/webpack/lib/webpack.js:145:16) at webpack (/home/test/dev/nx-enhance/node_modules/webpack/lib/webpack.js:153:47) at WebpackCLI.f [as webpack] (/home/test/dev/nx-enhance/node_modules/webpack/lib/index.js:73:16) at WebpackCLI.createCompiler (/home/test/dev/nx-enhance/node_modules/webpack-cli/lib/webpack-cli.js:1785:29) at async WebpackCLI.runWebpack (/home/test/dev/nx-enhance/node_modules/webpack-cli/lib/webpack-cli.js:1877:20) Warning: command "webpack-cli build --node-env=production" exited with non-zero status code Process finished with exit code 1 ``` ## Expected Behavior No error and the build is working. ## Related Issue(s) #26303 (cherry picked from commit 0e083fa)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Hello!
I fixing issue related to nx project with enhanced webpack config.
I created this repository to reproduce the bug: https://github.com/NicolasBelliard/nx-enhance-example
Current Behavior
When created an Nx repository with nx enhanced config, we faced the current issue when we try to build the application.
Expected Behavior
No error and the build is working.
Related Issue(s)
#26303