feat(module-federation): use proxy servers to proxy to single file server for static remotes #26782
+253
−380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e3dcd49. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
mf/use-express-proxies
branch
from
c576e10 to
ba829f4
Compare
Coly010
force-pushed
the
mf/use-express-proxies
branch
from
7b2d218 to
d7bba68
Compare
Coly010
force-pushed
the
mf/use-express-proxies
branch
from
d7bba68 to
f22d782
Compare
Coly010
force-pushed
the
mf/use-express-proxies
branch
from
700a473 to
69666a8
Compare
ndcunningham
force-pushed
the
mf/use-express-proxies
branch
from
69666a8 to
d616f59
Compare
ndcunningham
force-pushed
the
mf/use-express-proxies
branch
from
d616f59 to
914edbc
Compare
ndcunningham
force-pushed
the
mf/use-express-proxies
branch
from
914edbc to
c48d7e2
Compare
jaysoo
force-pushed
the
mf/use-express-proxies
branch
from
c48d7e2 to
e49f239
Compare
jaysoo
force-pushed
the
mf/use-express-proxies
branch
from
e49f239 to
a9be846
Compare
jaysoo
force-pushed
the
mf/use-express-proxies
branch
from
a9be846 to
1f1a2b3
Compare
jaysoo
force-pushed
the
mf/use-express-proxies
branch
from
1f1a2b3 to
89f08ae
Compare
jaysoo
reviewed
Jul 17, 2024
| @@ -39,7 +40,6 @@ export async function* moduleFederationDevServerExecutor( | |||
| // Force Node to resolve to look for the nx binary that is inside node_modules | |||
| const nxBin = require.resolve('nx/bin/nx'); | |||
| const options = normalizeOptions(schema); | |||
| options.staticRemotesPort ??= options.port + 1; | |||
There was a problem hiding this comment.
Removed this because it needs to be defaulted from the results of getRemotes (just like in React). Otherwise there could be a port conflict if one of the dev remotes has a port that's host port + 1.
jaysoo
force-pushed
the
mf/use-express-proxies
branch
from
89f08ae to
3667681
Compare
jaysoo
force-pushed
the
mf/use-express-proxies
branch
from
3667681 to
08681b1
Compare
jaysoo
approved these changes
Jul 18, 2024
…rver for static remotes
Coly010
force-pushed
the
mf/use-express-proxies
branch
from
08681b1 to
dc622b9
Compare
4 tasks
Coly010
force-pushed
the
mf/use-express-proxies
branch
2 times, most recently
from
7b78039 to
e4bf406
Compare
Coly010
force-pushed
the
mf/use-express-proxies
branch
from
e4bf406 to
e3dcd49
Compare
|
Hi @Coly010, thanks a lot for this fix. Is there a documentation that I can look into understand how this works? |
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 22, 2024
…rver for static remotes (#26782) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Remotes that are served for a host are usually served from a single file server running on a single port. We perform some mapping logic during the build of the host application to update the locations the remotes can be found at to point to the single file server. This works, but it's also wrong, as it breaks the flow that users expect. It also breaks dynamic remotes. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Continue to serve the remotes from a single file server, as this helps reduce the amount of resources used on developers machines. Use express to create proxy servers that will proxy requests from the original remote location to the single file server. This allows applications to continue to work without us having to interfere and map any remote locations. It also solves the issue with dynamic remotes. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26318 (cherry picked from commit a549b9b)
|
@VanTigranyan No documentation as of yet, but it is coming. Essentially, the process is now
This means we continue to get the machine resource savings without doing any under the hood mapping of remote locations etc. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Remotes that are served for a host are usually served from a single file server running on a single port.
We perform some mapping logic during the build of the host application to update the locations the remotes can be found at to point to the single file server.
This works, but it's also wrong, as it breaks the flow that users expect.
It also breaks dynamic remotes.
Expected Behavior
Continue to serve the remotes from a single file server, as this helps reduce the amount of resources used on developers machines.
Use express to create proxy servers that will proxy requests from the original remote location to the single file server.
This allows applications to continue to work without us having to interfere and map any remote locations.
It also solves the issue with dynamic remotes.
Related Issue(s)
Fixes #26318