Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): add nx syncing mechanism and update the typescript-sync generator #26793

Merged
merged 26 commits into from
Aug 12, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jul 2, 2024

  • Add the nx sync command to run sync generators and apply changes to bring the workspace up to date according to their logic.
  • Add the nx sync:check command to validate that the workspace is up to date by running the sync generators without applying the changes. It can be used on CI as a validation check.
  • Update the task runner to run the sync generators (or obtain their state from the daemon) and prompt the user whether to apply the changes, if any
    • This is only run if the NX_ENABLE_SYNC_GENERATORS environment variable is set to 'true'
    • Allow the user to configure a default value for the prompt
  • Update the @nx/js:typescript-sync generator (keep tsconfig project references in sync with the project graph) with misc fixes

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Jul 2, 2024
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 7:38am

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-26793-c134574 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-26793-c134574
Release details 📑
Published version 0.0.0-pr-26793-c134574
Triggered by @leosvelperez
Branch js/update-sync-generator
Commit c134574
Workflow run 9872774870

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@leosvelperez leosvelperez force-pushed the js/update-sync-generator branch from c134574 to b9df4dd Compare July 18, 2024 09:12
@leosvelperez leosvelperez force-pushed the js/update-sync-generator branch 8 times, most recently from ba8f1fe to 6e5bfad Compare August 1, 2024 07:38
Copy link

github-actions bot commented Aug 1, 2024

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-26793-6e5bfad my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-26793-6e5bfad
Release details 📑
Published version 0.0.0-pr-26793-6e5bfad
Triggered by @leosvelperez
Branch js/update-sync-generator
Commit 6e5bfad
Workflow run 10195507596

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@leosvelperez leosvelperez force-pushed the js/update-sync-generator branch 5 times, most recently from cd98ca2 to a774083 Compare August 6, 2024 14:37

Verified

This commit was signed with the committer’s verified signature.
FrozenPandaz Jason Jean
@leosvelperez leosvelperez force-pushed the js/update-sync-generator branch from f10a109 to f306648 Compare August 12, 2024 07:36
Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-26793-f306648 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-26793-f306648
Release details 📑
Published version 0.0.0-pr-26793-f306648
Triggered by @leosvelperez
Branch js/update-sync-generator
Commit f306648
Workflow run 10349496915

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@FrozenPandaz FrozenPandaz merged commit add5a67 into master Aug 12, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the js/update-sync-generator branch August 12, 2024 14:44
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants