fix(node): ensure artifacts are built before serving app #27146
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d888e34. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Coly010
approved these changes
Jul 26, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 30, 2024
This PR ensures that all dependencies are built before serving the Node app. <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior If users don't manually run `nx build <app>` first, then the dependencies won't build because when `@nx/js:node` executor runs, it uses `runExecutor` which skips dependencies. ## Expected Behavior Set `dependsOn` on the `serve` target so run `<app>:build` first, which would ensure dependencies are all built. Also add `runBuildTargetDependencies: false` to the target options for visibility, so users could toggle it on if they want to re-build deps whenever there is a change (during watch). The option will slow things down, so we still want it to be `false` by default. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #18964 (cherry picked from commit b3d7509)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that all dependencies are built before serving the Node app.
Current Behavior
If users don't manually run
nx build <app>first, then the dependencies won't build because when@nx/js:nodeexecutor runs, it usesrunExecutorwhich skips dependencies.Expected Behavior
Set
dependsOnon theservetarget so run<app>:buildfirst, which would ensure dependencies are all built. Also addrunBuildTargetDependencies: falseto the target options for visibility, so users could toggle it on if they want to re-build deps whenever there is a change (during watch). The option will slow things down, so we still want it to befalseby default.Related Issue(s)
Fixes #18964