Skip to content

feat(release): allow {releaseGroupName} to be interpolated in releaseTagPattern #27188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

There is no way to interpolate the release group name in the releaseTagPattern, so for workspaces with a lot of groups, a lot of repetition is required.

Expected Behavior

{releaseGroupName} will now get interpolated in the tag pattern for release groups with fixed versioning (independent projects are still based on the {projectName} as before)

Related Issue(s)

Fixes #

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…tern
@JamesHenry JamesHenry requested review from a team as code owners July 29, 2024 16:30
@JamesHenry JamesHenry requested review from AgentEnder and jaysoo July 29, 2024 16:30
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev 🔄 Building (Inspect) Visit Preview Jul 29, 2024 4:30pm

@JamesHenry JamesHenry changed the title feat(release): allow {releaseGroupName} to be interpolated in tag pattern feat(release): allow {releaseGroupName} to be interpolated in releaseTagPattern Jul 29, 2024
@JamesHenry JamesHenry merged commit 0b9672b into master Jul 29, 2024
3 of 5 checks passed
@JamesHenry JamesHenry deleted the release-tag-pattern-group branch July 29, 2024 16:31
JamesHenry added a commit that referenced this pull request Jul 29, 2024

Partially verified

This commit is signed with the committer’s verified signature.
FrozenPandaz’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
… releaseTagPattern" (#27189)

Reverts #27188
@JamesHenry JamesHenry restored the release-tag-pattern-group branch July 29, 2024 16:32
@JamesHenry
Copy link
Collaborator Author

Accidentally merged before checks and reviews could complete, immediately reverted in #27189

@JamesHenry JamesHenry deleted the release-tag-pattern-group branch July 29, 2024 21:55
FrozenPandaz pushed a commit that referenced this pull request Jul 30, 2024
FrozenPandaz pushed a commit that referenced this pull request Jul 30, 2024
… releaseTagPattern" (#27189)

Reverts #27188

(cherry picked from commit 9e6c7fa)
Copy link

github-actions bot commented Aug 4, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant