feat(nx-cloud): add nxCloudId field for auth #27197
Merged
+184
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 963a99b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
lourw
force-pushed
the
feature/inf-1176-update-nx-to-recognize-nxcloudid
branch
from
0fa0e84 to
7dca4f8
Compare
AgentEnder
approved these changes
Jul 30, 2024
leosvelperez
approved these changes
Jul 30, 2024
StalkAltan
reviewed
Jul 30, 2024
MaxKless
approved these changes
Aug 6, 2024
lourw
force-pushed
the
feature/inf-1176-update-nx-to-recognize-nxcloudid
branch
2 times, most recently
from
012b696 to
8690d28
Compare
lourw
commented
Aug 6, 2024
| @@ -31,6 +31,7 @@ Nx.json configuration | |||
| - [neverConnectToCloud](../../devkit/documents/NxJsonConfiguration#neverconnecttocloud): boolean | |||
| - [nxCloudAccessToken](../../devkit/documents/NxJsonConfiguration#nxcloudaccesstoken): string | |||
| - [nxCloudEncryptionKey](../../devkit/documents/NxJsonConfiguration#nxcloudencryptionkey): string | |||
| - [nxCloudId](../../devkit/documents/NxJsonConfiguration#nxcloudid): string | |||
There was a problem hiding this comment.
Spoke with Isaac, it's not a huge deal to leave these in the devkit docs for now. The main docs for nx-cloud login will come with an upcoming PR.
lourw
force-pushed
the
feature/inf-1176-update-nx-to-recognize-nxcloudid
branch
from
8690d28 to
ede415d
Compare
lourw
force-pushed
the
feature/inf-1176-update-nx-to-recognize-nxcloudid
branch
from
ede415d to
963a99b
Compare
ZackDeRose
pushed a commit
to ZackDeRose/nx
that referenced
this pull request
Aug 8, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Instead of `nxCloudAccessToken`, users can now connect to nx-cloud with `nxCloudId`. This value will also default the runner to the cloud runner. Also modified the `connect-to-nx-cloud` generator such that it hits a new API endpoint to grab a workspace's nxCloudId instead of access token. (This feature is gated). ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Instead of
nxCloudAccessToken, users can now connect to nx-cloud withnxCloudId. This value will also default the runner to the cloud runner.Also modified the
connect-to-nx-cloudgenerator such that it hits a new API endpoint to grab a workspace's nxCloudId instead of access token. (This feature is gated).Related Issue(s)
Fixes #