Skip to content

feat(storybook): add storybook 8 support #27214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Aug 14, 2024
Merged

feat(storybook): add storybook 8 support #27214

merged 24 commits into from
Aug 14, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jul 30, 2024

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #27175 #26914 #22941 #26531

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 3:29pm

@@ -137,5 +137,5 @@ To serve the `store` application and watch for changes on the `checkout` applica

To learn more about Module Federation, we have some resources you might find useful:

- [Guide: Faster Builds with Module Federation](/concepts/module-federation/faster-builds-with-module-federation)
- [Guide: Faster Builds with Module Federation](/concepts/module-federation/faster-builds-with-module-federation)hel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it was added accidentally.

@Coly010 Coly010 force-pushed the storybook-8-support branch from 6515114 to 331461b Compare August 14, 2024 14:19
@Coly010 Coly010 force-pushed the storybook-8-support branch from 331461b to fe7f53d Compare August 14, 2024 15:27
@Coly010 Coly010 merged commit 11f30db into master Aug 14, 2024
6 checks passed
@Coly010 Coly010 deleted the storybook-8-support branch August 14, 2024 15:37
@lppedd
Copy link

lppedd commented Aug 14, 2024

Just to be sure, if I'm currently on 18.3.4 with Storybook 7, will the migration to 19.6.0 (nx migrate latest) offer an automatic migration to v8, or do I have to run that manually?

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request to add migration to storybook 8 using nx schematic generator in upcoming version
6 participants