fix(release): allow version plans to have multi-line, arbitrarily formatted messages #27323
+274
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cd2298e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
fahslaj
previously requested changes
Aug 7, 2024
fahslaj
approved these changes
Aug 7, 2024
FrozenPandaz
approved these changes
Aug 7, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In order to land experimental version plans support, we temporarily kept the changelog messages coupled to conventional commits, even though they really should be completely unrelated.
Expected Behavior
Messages in version plans are not constrained to be single line conventional commit style messages. They can have any structure and be of any length (including newlines).
The
nx release plancommand now helpfully provides an interactive editor experience for the message if you submit an empty value (the prompt explains this inline).Related Issue(s)
Fixes #