fix(nx-cloud): add nxCloudId to nxJson when connecting with generator #27356
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1e3fae3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
StalkAltan
approved these changes
Aug 9, 2024
lourw
force-pushed
the
lourw/fix-nx-json-when-connecting
branch
from
f6aeeec to
c140031
Compare
lourw
force-pushed
the
lourw/fix-nx-json-when-connecting
branch
from
c140031 to
59c311b
Compare
lourw
force-pushed
the
lourw/fix-nx-json-when-connecting
branch
from
59c311b to
1e3fae3
Compare
JamesHenry
approved these changes
Aug 12, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When connecting via NxCloudId, the resulting Id would not be written to nx.json
Expected Behavior
Correctly writes nxCloudId to nx.json after running
npx nx g connect-to-nx-cloudRelated Issue(s)
Fixes #