Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): prevent post install failures when socket path too long #27366

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

We communicate with sockets during graph construction. Its possible for the assigned path to be too long and this can cause issues. The issues present as a strange error with no helpful information.

Expected Behavior

There is a helpful error message, and post-install is not interrupted

Related Issue(s)

Fixes #27040

@AgentEnder AgentEnder requested review from a team as code owners August 9, 2024 19:54
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Aug 9, 2024 9:17pm

@AgentEnder AgentEnder merged commit abfb25d into master Aug 10, 2024
6 checks passed
@AgentEnder AgentEnder deleted the fix/socket-path-too-long branch August 10, 2024 03:15
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent Postinstall error for node 18.20.3
2 participants