Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): e2e-ci targetDefaults migration should handle self deps #27380

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 12, 2024

Current Behavior

If the ciWebServerCommand depends on a target that exists on the e2e project, the dependsOn is still added with ^ expecting the project to be an implicit dep.

Expected Behavior

The migration should handle when e2e project depends on itself for the e2e-ci command

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner August 12, 2024 11:43
@Coly010 Coly010 self-assigned this Aug 12, 2024
@Coly010 Coly010 requested a review from JamesHenry August 12, 2024 11:43
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 2:27pm

@jaysoo jaysoo merged commit ef036b4 into master Aug 12, 2024
6 checks passed
@jaysoo jaysoo deleted the testing/e2e-ci-handles-self-deps branch August 12, 2024 18:19
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants