Skip to content

fix(release): allow specifier override for version command when version plans are enabled #27436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Aug 14, 2024

Current Behavior

Specifier overrides are implicitly allowed for the version and release commands.

Expected Behavior

Specifier overrides are explicitly allowed for the version subcommand, but not allowed for the release command.

// This will correctly override version plans, even if they are enabled
$ nx release version minor

// This is not allowed if version plans are enabled
$ nx release minor

Related Issue(s)

Fixes #

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 6:02pm

@fahslaj fahslaj requested a review from JamesHenry August 14, 2024 17:01
@fahslaj fahslaj force-pushed the feat/imperative-versioning-081424 branch from fdfc03a to 44d95f0 Compare August 14, 2024 17:01
@fahslaj fahslaj marked this pull request as ready for review August 14, 2024 17:01
@fahslaj fahslaj requested a review from a team as a code owner August 14, 2024 17:01
@JamesHenry JamesHenry changed the title feat(release): explicitly allow specifier override for version command when version plans are enabled fix(release): explicitly allow specifier override for version command when version plans are enabled Aug 14, 2024
@JamesHenry JamesHenry changed the title fix(release): explicitly allow specifier override for version command when version plans are enabled fix(release): allow specifier override for version command when version plans are enabled Aug 14, 2024
@JamesHenry JamesHenry enabled auto-merge (squash) August 14, 2024 17:26
@JamesHenry JamesHenry merged commit 4d27939 into master Aug 14, 2024
6 checks passed
@JamesHenry JamesHenry deleted the feat/imperative-versioning-081424 branch August 14, 2024 18:35
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants