Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support import detection of packages installed from git remote URL #27569

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 21, 2024

This PR fixes an issue where installing a package from git remote URL will result in it not being picked up by Nx as a dependency whenever it is used in a project.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #27423

@jaysoo jaysoo requested a review from a team as a code owner August 21, 2024 18:28
@jaysoo jaysoo requested a review from Cammisuli August 21, 2024 18:28
Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 7:39pm

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…mote URL
@JamesHenry JamesHenry merged commit 16b2e02 into master Aug 21, 2024
6 checks passed
@JamesHenry JamesHenry deleted the issue/27423 branch August 21, 2024 21:16
FrozenPandaz pushed a commit that referenced this pull request Aug 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…mote URL (#27569)

(cherry picked from commit 16b2e02)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build with generating a package.json is missing a GitHub package
3 participants