Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(repo): make circleci jobs parametrised for running on different environments #6709

Merged
merged 7 commits into from Aug 16, 2021
Merged

chore(repo): make circleci jobs parametrised for running on different environments #6709

merged 7 commits into from Aug 16, 2021

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Aug 13, 2021 •
edited

Current Behavior

Our CircleCI config runs two main jobs:

  • pr-main responsible for checking the pull requests
  • trunk-main responsible for checking the commits to master

Most of the code between those two is duplicated, only difference being that pr-main checks also docs, format, commit etc. and trunk-main runs cypress tests.

Also, both of them are running only on linux with pnpm

Expected Behavior

  • The jobs should be parametrised so that we can reuse the same setup
  • We should be able to run both on different environments making sure the agent cleanup is still working
  • We should be able to select what targets we want to run and be able to apply filters

Related Issue(s)

This will allow us to run iOS and Android tests on a separate machines as part of the same workflow.
This is a important for #6493

@vercel
Copy link

vercel bot commented Aug 13, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/HzHpMGYBrswDdk3pV6ghLaUWjafe
✅ Preview: https://nx-dev-git-fork-meeroslav-chore-check-optional-repo-runs-nrwl.vercel.app

@meeroslav meeroslav force-pushed the chore/check-optional-repo-runs branch from 6a87e22 to ed8ca9c Compare August 13, 2021 11:21
@nx-cloud
Copy link

nx-cloud bot commented Aug 13, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 12b504c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=e2e --base=0cb247c3b38642340ed1fa82d59c395089b8cc05
#000000 nx affected --target=lint --base=0cb247c3b38642340ed1fa82d59c395089b8cc05 --parallel --max-parallel=4
#000000 nx affected --target=test --base=0cb247c3b38642340ed1fa82d59c395089b8cc05 --parallel --max-parallel=2
#000000 nx affected --target=build --base=0cb247c3b38642340ed1fa82d59c395089b8cc05 --parallel --max-parallel=3
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

@meeroslav meeroslav force-pushed the chore/check-optional-repo-runs branch 3 times, most recently from 2799e18 to f6f643e Compare August 13, 2021 11:33
@meeroslav meeroslav force-pushed the chore/check-optional-repo-runs branch from f6f643e to 81888a9 Compare August 13, 2021 12:00
@meeroslav meeroslav force-pushed the chore/check-optional-repo-runs branch 3 times, most recently from 148168d to 252429a Compare August 13, 2021 12:23
@meeroslav meeroslav force-pushed the chore/check-optional-repo-runs branch from 252429a to 6b70b66 Compare August 13, 2021 13:13
@meeroslav meeroslav force-pushed the chore/check-optional-repo-runs branch from 6b70b66 to 5fe290c Compare August 13, 2021 13:25
@meeroslav meeroslav changed the title chore(repo): run optional targets chore(repo): make jobs parametrised for running on different environments Aug 13, 2021
@meeroslav meeroslav changed the title chore(repo): make jobs parametrised for running on different environments chore(repo): make circleci jobs parametrised for running on different environments Aug 13, 2021
@meeroslav meeroslav self-assigned this Aug 13, 2021
@meeroslav meeroslav force-pushed the chore/check-optional-repo-runs branch from e064583 to 09f3954 Compare August 13, 2021 17:12
@meeroslav meeroslav force-pushed the chore/check-optional-repo-runs branch from def6a0c to e143c45 Compare August 16, 2021 08:40
@meeroslav meeroslav force-pushed the chore/check-optional-repo-runs branch from e143c45 to 12b504c Compare August 16, 2021 12:12
@meeroslav meeroslav marked this pull request as ready for review August 16, 2021 13:40
@meeroslav meeroslav merged commit b787eaf into nrwl:master Aug 16, 2021
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@meeroslav @ManojBahuguna
chore(repo): make circleci jobs parametrised for running on different…
80daf72 
… environments (nrwl#6709)
@meeroslav meeroslav deleted the chore/check-optional-repo-runs branch October 18, 2021 12:36
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@meeroslav meeroslav

Labels
scope: repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@meeroslav