fix(core): configFilePath included in hash #6881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/8itJLTPnHvDYLVKzxsZymoyC5Y8G |
Nx Cloud ReportCI ran the following commands for commit 148a185. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
FrozenPandaz
approved these changes
Aug 31, 2021
sumitparakh
pushed a commit
to sumitparakh/nx
that referenced
this pull request
Sep 1, 2021
ManojBahuguna
pushed a commit
to ManojBahuguna/nx
that referenced
this pull request
Sep 16, 2021
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
workspace.readWorkspaceConfiguration() includes
configFilePath, which is only necessary forngcli-adapterto know where to save configurations.Expected Behavior
workspace.readWorkspaceConfiguration() doesnt include
configFilePath, which is only necessary forngcli-adapterto know where to save configurations.Related Issue(s)
Fixes #6880