fix(core): gracefully handle errors when writing the latest output hash cache files

[minijus]

Instead of failing the task run process it will allow the process to continue.

Fixes of #6957

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/7s44TAfKXvMDhPwwPDinPQzpDsR3
✅ Preview: Canceled

[Deployment for f6b611e canceled]

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit f6b611e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx affected --target=build --base=2d934093b0859d8cf487d1f68187110085998d95 --parallel --max-parallel=3
	nx affected --target=e2e --base=2d934093b0859d8cf487d1f68187110085998d95 --exclude=e2e-next,e2e-gatsby,e2e-workspace,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-storybook,e2e-cypress,e2e-node,e2e-linter,e2e-jest -- --t=MACOS-Tests
	nx affected --target=e2e --base=2d934093b0859d8cf487d1f68187110085998d95 --exclude=e2e-react-native,e2e-detox
	nx affected --target=lint --base=2d934093b0859d8cf487d1f68187110085998d95 --parallel --max-parallel=4
	nx affected --target=test --base=2d934093b0859d8cf487d1f68187110085998d95 --parallel --max-parallel=2
	nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[leosvelperez]

@minijus thanks for contributing!

A try..catch there definitely wouldn't hurt, but before committing that change, I'd like to understand better when or why this issue happens. I saw you mentioned in this comment that it's only happening on lint executions, is that so? If that's the case, are you able to come up with a scenario where I can reproduce it?

[minijus]

@leosvelperez Nx local cache solution is written in a way that it never considers failures of atomic fs operations. Usually, that never happens - especially on single dev machine.

However, using local cache on CI where cache directory is mounted is another story. In our case we mount NFS based cache volume to CI builds. There are many parallel reads/writes to that directory and sometimes they fail. Ideally cache implementation should be written in a way that failure to read/write cache would not impact the run itself, instead it would fallback to running actual task.

[leosvelperez]

@minijus I agree, I didn't say otherwise :)

Applying this fix is not in doubt, but we might be hiding another issue looking at your comment here where you say It does seem that failures on cache read are happening only on lint tasks. That's what I want to understand. Could you please clarify if this is only happening when linting and how could I reproduce it?

[minijus]

We have started seeing this failures only on 12.9 (there were no failures on 12.8). The difference is that 12.9 adds "outputs": ["{options.outputFile}"]to lint task definition in angular.json. I am not sure if that is the root cause, but it could be related.

[leosvelperez]

Thanks for contributing!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.