Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add JSON schema for nx.json #7993

Closed
wants to merge 1 commit into from

Conversation

puku0x
Copy link
Contributor

@puku0x puku0x commented Dec 3, 2021

Current Behavior

No auto-completion for nx.json.

Expected Behavior

Auto-completion for nx.json is available 🙌

// nx.json
{
  "$schema": "./node_modules/@nrwl/tao/src/config/schema.json",
  "implicitDependencies": {
  :
}

image

Related Issue(s)

Refs #2299
https://github.com/nrwl/nx/blob/e02c02cf709417cf43c4cb363c41888c3e0ed150/packages/tao/src/shared/nx.ts
https://nx.dev/l/r/core-concepts/configuration#configuration

Will be added to schema store in the future?
https://github.com/SchemaStore/schemastore

@vercel
Copy link

vercel bot commented Dec 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/GsQVrHNJXY71wFLfCpb2P2T15rCF
✅ Preview: Canceled

[Deployment for 9572499 canceled]

@puku0x
Copy link
Contributor Author

puku0x commented Dec 4, 2021

Nx Console does similar thing for workspace.json. nrwl/nx-console#1077

@puku0x
Copy link
Contributor Author

puku0x commented Dec 4, 2021

This PR can be closed after nrwl/nx-console#1186 is merged.

@puku0x
Copy link
Contributor Author

puku0x commented Dec 5, 2021

Almost done. nrwl/nx-console@81be231

@puku0x
Copy link
Contributor Author

puku0x commented Dec 5, 2021

Closing due to nrwl/nx-console#1186 was merged.
Nx Console will help us to auto-complete nx.json soon.

@puku0x puku0x closed this Dec 5, 2021
@puku0x puku0x deleted the 2299-chore-nx-json-schema branch December 11, 2021 08:33
@puku0x
Copy link
Contributor Author

puku0x commented Dec 11, 2021

Please use Nx console.
https://github.com/nrwl/nx-console/releases/tag/v17.13.0

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant