fix(storybook): apply a webpack tweak for storybook and angular #8392
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/Etc3UExBiFxtHP7jpmLymbww7aAW [Deployment for 79ed1d9 canceled] |
|
@mandarini review please. Please let me know if I modified the correct file, and if I should make any other changes. PS: Unit tests are failing. I'll run tests locally, and will convert the PR to ready for review once it passes. |
- [x] remove html raw-loader from the webpack rules array if storybook is used with angular v13; the html raw-loader breaks jit compilation when storybook 6.5 aplha is used with angular v13 ISSUES CLOSED: #8360 fix(testing): update storybook generator configuration snapshot fix(testing): update storybook generator configuration snapshot, use the flag --update-snapshot fix(testing): update storybook generator configuration snapshot, test affected, update snapshot
|
Thank you for this PR @rfprod ! Thank you so much for contributing to Nx!!! |
| * Remove html raw loader that breaks Jit compilation as suggested here https://github.com/storybookjs/storybook/issues/16977#issuecomment-1004059631. | ||
| * The issue references: | ||
| * - https://github.com/storybookjs/storybook/issues/16977#issuecomment-1003399336 | ||
| * - https://github.com/storybookjs/storybook/issues/16977#issuecomment-1004180729 | ||
| * Here's what should be removed: | ||
| * { | ||
| * test: /\.html$/, | ||
| * loader: './node_modules/raw-loader/dist/cjs.js', | ||
| * exclude: /\.async\.html$/ | ||
| * }, | ||
| */ |
There was a problem hiding this comment.
Do you think we could make this comment smaller, or maybe remove the github issue references/links, and just keep the explanation? (the Jit breaking, and what needs to be removed for example)?
There was a problem hiding this comment.
Sure, I will remove it in a while once I'm around my laptop.
There was a problem hiding this comment.
Sure, no rush! I'll take a look tomorrow my morning in any case! :D
There was a problem hiding this comment.
@mandarini I made the change you requested.
…explanation more concise
|
Works like a charm, thank you! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
the html raw-loader breaks jit compilation when storybook 6.5 aplha is used with angular v13
ISSUES CLOSED: #8360
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #8360