feat(core): ability to run local nx plugins #9029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI is running for commit fdf3de5. 📂 Click to track the progress, see the status, the terminal output, and the build insights. Sent with 💌 from NxCloud. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/GDhxAA47weuUmARykYBhJ3AtoSW7 [Deployment for fdf3de5 canceled] |
AgentEnder
force-pushed
the
feat/local-nx-plugins
branch
from
b9fc67f
to
6a05080
Compare
AgentEnder
force-pushed
the
feat/local-nx-plugins
branch
from
6a05080
to
227d5b2
Compare
AgentEnder
force-pushed
the
feat/local-nx-plugins
branch
from
227d5b2
to
7641644
Compare
|
CC @vsavkin @FrozenPandaz whenever either of you are ready to review ping me, I'd like to talk through some of the changes on this one. |
AgentEnder
force-pushed
the
feat/local-nx-plugins
branch
from
a7eb255
to
2c4afe7
Compare
AgentEnder
force-pushed
the
feat/local-nx-plugins
branch
from
2c4afe7
to
df0c97f
Compare
AgentEnder
force-pushed
the
feat/local-nx-plugins
branch
from
df0c97f
to
fdf3de5
Compare
AgentEnder
force-pushed
the
feat/local-nx-plugins
branch
from
fdf3de5
to
7641644
Compare
|
Superceded by #9116 |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Nx plugins are loaded through a combination of
require.resolveandrequire. In order for this to work for plugins that were created and live as a project in the workspace, that project must be built and available via NODE_PATH (sometime's done by symlinking outputs to node_modules).This complicates the setup for workspace executors, as dev's must setup some kind of automated build before the command. This can be done either using targetDependencies or a clever post install script, but neither are really ideal.
Expected Behavior
Created nx plugins' functionality is available to the CLI, in the same manner that an installed plugin would be.
Related Issue(s)
Fixes #8824
Fixes #3231