Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add more descriptive dependencies build error #9031

Merged
merged 3 commits into from Mar 28, 2022
Merged

fix(core): add more descriptive dependencies build error #9031

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
867936c
fix(core): add more descriptive dependencies build error
yharaskrik Feb 18, 2022
c4e761b
fix(core): check for no projects missing before showing error
yharaskrik Mar 23, 2022
26614df
chore(repo): nx format
AgentEnder Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/workspace/src/utilities/buildable-libs-utils.ts
View file
Open in desktop
Expand Up @@ -208,7 +208,15 @@ export function checkDependentProjectsHaveBeenBuilt(
targetName,
projectDependencies
);
if (missing.length > 0) {
if (missing.length === projectDependencies.length && missing.length > 0) {
console.error(stripIndents`
It looks like all of ${projectName}'s dependencies have not been built yet:
${missing.map((x) => ` - ${x.node.name}`).join('\n')}

You might be missing a "targetDependencies" configuration in your root nx.json (https://nx.dev/configuration/packagejson#target-dependencies),
or "dependsOn" configured in ${projectName}'s angular.json/workspace.json record or project.json (https://nx.dev/configuration/packagejson#dependson)
`);
} else if (missing.length > 0) {
console.error(stripIndents`
Some of the project ${projectName}'s dependencies have not been built yet. Please build these libraries before:
${missing.map((x) => ` - ${x.node.name}`).join('\n')}
Expand Down