New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js): update dependencies in package.json #9073
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/2CDT368phn2WFgQvLffkm9SyeZmE |
Also removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you
Co-authored-by: Jason Gerbes <jason.gerbes@vista.co>
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The
@nrwl/js:tsc
and@nrwl/js:swc
executors update themain
andtypings
properties of the outputpackage.json
file, but they don't currently update thedependencies
/peerDependencies
properties.This behaviour is inconsistent with
@nrwl/node:package
,@nrwl/angular:package
, and@nrwl/web:rollup
executors that do update thedependencies
/peerDependencies
properties based on the project graph.Expected Behavior
The
@nrwl/js:tsc
and@nrwl/js:swc
executors should update thedependencies
/peerDependencies
based on the project graph.The
updateBuildableProjectDepsInPackageJson
andbuildableProjectDepsInPackageJsonType
options used by other executors should also be exposed to allow this behaviour to be configurable.Related Issue(s)
Fixes #8945