Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): align root karma config when migrating from angular cli to match the one for new workspaces #9144

Merged
merged 1 commit into from Feb 28, 2022
Merged

fix(angular): align root karma config when migrating from angular cli to match the one for new workspaces #9144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/angular/src/generators/karma/files/karma.conf.js__tmpl__
View file
Open in desktop
Expand Up @@ -24,6 +24,9 @@ module.exports = () => {
},
clearContext: false, // leave Jasmine Spec Runner output visible in browser
},
jasmineHtmlReporter: {
suppressAll: true, // removes the duplicated traces
},
coverageReporter: {
dir: join(__dirname, './coverage'),
subdir: '.',
Expand Down
19 changes: 14 additions & 5 deletions .../generators/init/files/root/karma.conf.js → ...ors/init/files/root/karma.conf.js__tmpl__
View file
Open in desktop
Expand Up @@ -12,16 +12,25 @@ module.exports = () => {
require('karma-jasmine'),
require('karma-chrome-launcher'),
require('karma-jasmine-html-reporter'),
require('karma-coverage-istanbul-reporter'),
require('karma-coverage'),
require('@angular-devkit/build-angular/plugins/karma'),
],
client: {
jasmine: {
// you can add configuration options for Jasmine here
// the possible options are listed at https://jasmine.github.io/api/edge/Configuration.html
// for example, you can disable the random execution with `random: false`
// or set a specific seed with `seed: 4321`
},
clearContext: false, // leave Jasmine Spec Runner output visible in browser
},
coverageIstanbulReporter: {
dir: join(__dirname, '../../coverage'),
reports: ['html', 'lcovonly'],
fixWebpackSourcePaths: true,
jasmineHtmlReporter: {
suppressAll: true, // removes the duplicated traces
},
coverageReporter: {
dir: join(__dirname, './coverage'),
subdir: '.',
reporters: [{ type: 'html' }, { type: 'text-summary' }],
},
reporters: ['progress', 'kjhtml'],
port: 9876,
Expand Down
0 ...init/files/root/tools/schematics/.gitkeep → ...iles/root/tools/schematics/__dot__gitkeep
View file
Open in desktop
File renamed without changes.
0 ...init/files/root/tools/tsconfig.tools.json → ...es/root/tools/tsconfig.tools.json__tmpl__
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions packages/workspace/src/generators/init/init.ts
View file
Open in desktop
Expand Up @@ -823,6 +823,7 @@ function decorateAngularClI(host: Tree) {
function addFiles(host: Tree) {
generateFiles(host, joinPathFragments(__dirname, './files/root'), '.', {
tmpl: '',
dot: '.',
});

if (!host.exists('.prettierignore')) {
Expand Down
6 changes: 0 additions & 6 deletions scripts/depcheck/missing.ts
View file
Open in desktop
Expand Up @@ -99,14 +99,8 @@ const IGNORE_MATCHES = {
workspace: [
'tslint',
'@angular-devkit/architect',
'@angular-devkit/build-angular',
'@angular-devkit/core',
'@angular-devkit/schematics',
'karma',
'karma-chrome-launcher',
'karma-coverage-istanbul-reporter',
'karma-jasmine',
'karma-jasmine-html-reporter',
'webpack',
'webpack-dev-server',
'@nrwl/cli',
Expand Down