New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): support workspaces using a root tsconfig.json instead of tsconfig.base.json #9178
Conversation
…f tsconfig.base.json
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/DophuEj9hs4gnfhkuQT8gi2krRtP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Closing in favor of #9195. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Several generators in the Angular plugin don't fall back to locate a root
tsconfig.json
if the expectedtsconfig.base.json
doesn't exist.Most of the time this should be fine since Nx workspaces by default use
tsconfig.base.json
, but there are still some scenarios where atsconfig.json
might still be used. One such scenario is using a package likemake-angular-cli-faster
or migrating an Angular CLI workspace using the--preserve-angular-cli-layout
flag.Expected Behavior
The Angular plugin generators should look for a root
tsconfig.json
if thetsconfig.base.json
file doesn't exist. By default,tsconfig.base.json
should still be used for everything, but a fallback should be in place.Related Issue(s)
Fixes #