Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): support workspaces using a root tsconfig.json instead of tsconfig.base.json #9178

Closed
wants to merge 1 commit into from

Conversation

leosvelperez
Copy link
Member

Current Behavior

Several generators in the Angular plugin don't fall back to locate a root tsconfig.json if the expected tsconfig.base.json doesn't exist.

Most of the time this should be fine since Nx workspaces by default use tsconfig.base.json, but there are still some scenarios where a tsconfig.json might still be used. One such scenario is using a package like make-angular-cli-faster or migrating an Angular CLI workspace using the --preserve-angular-cli-layout flag.

Expected Behavior

The Angular plugin generators should look for a root tsconfig.json if the tsconfig.base.json file doesn't exist. By default, tsconfig.base.json should still be used for everything, but a fallback should be in place.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 3, 2022
@vercel
Copy link

vercel bot commented Mar 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/DophuEj9hs4gnfhkuQT8gi2krRtP
✅ Preview: Canceled

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@nx-cloud
Copy link

nx-cloud bot commented Mar 3, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit df533df. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez marked this pull request as draft March 3, 2022 21:27
@leosvelperez
Copy link
Member Author

Closing in favor of #9195.

@leosvelperez leosvelperez deleted the angular/root-tsconfig branch March 21, 2022 12:20
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants