fix(js): remove hardcoded source-maps option from swc compile command

[Tirke]

ISSUES CLOSED: #9187

Current Behavior

nx/packages/js/src/utils/swc/compile-swc.ts

Line 13 in 229f71e

let swcCmd = `npx swc ${srcPath} -d ${destPath} --source-maps --no-swcrc --config-file=${swcrcPath}`;

--source-maps is hardcoded so adding "sourceMaps": false, to your .swcrc has no effect.
Is there any reason why this parameter is hardcoded?

Expected Behavior

I should be able to disable sourcemaps on swc compile.

Related Issue(s)

Fixes #9187

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 7b36619. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 7 targets

• nx affected --target=build --base=229f71ef1758ee625869aaa6fa6355dc3284fa5b --head=7b366195f1814318c4de66ff3f0948a0d3101946 --parallel=3
• nx affected --target=e2e --base=229f71ef1758ee625869aaa6fa6355dc3284fa5b --head=7b366195f1814318c4de66ff3f0948a0d3101946 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=229f71ef1758ee625869aaa6fa6355dc3284fa5b --head=7b366195f1814318c4de66ff3f0948a0d3101946 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=229f71ef1758ee625869aaa6fa6355dc3284fa5b --head=7b366195f1814318c4de66ff3f0948a0d3101946 --parallel=3
• nx affected --target=test --base=229f71ef1758ee625869aaa6fa6355dc3284fa5b --head=7b366195f1814318c4de66ff3f0948a0d3101946 --parallel=1
• nx build typedoc-theme
• nx run-many --target=build --all --parallel=8 --exclude=docs,nx-dev-data-access-documents,nx-dev-e2e,nx-dev,nx-dev-feature-analytics,nx-dev-feature-conf,nx-dev-feature-doc-viewer,nx-dev-feature-search,nx-dev-feature-storage,nx-dev-feature-versions-and-flavors,nx-dev-ui-commands,nx-dev-ui-common,nx-dev-ui-home,nx-dev-ui-member-card,nx-dev-ui-sponsor...

---

Sent with 💌 from NxCloud.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/EyTm4MqDPDovRDeaaNqu6G2SC9TP
✅ Preview: Canceled

[nartc]

Thank you @Tirke for the contribution. However, removing just the hardcoded portion from the CLI command isn't enough. Since the behavior has been "sourceMaps is always true", we'd need to update .swcrc to include sourceMaps: true by default to not break people.

That said, I've been working on adjusting .swcrc as a separate story so I included the fix in my PR as well. #9198

[Tirke]

@nartc Thanks for taking time to respond.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.