Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): npm modules are not resolved correctly #9284

Merged
merged 1 commit into from Mar 18, 2022

Commits on Mar 11, 2022

  1. fix(node): npm modules are not resolved correctly

    The current implementation of the node executor resolves all npm
    modules that are referenced by the application from the root
    node_modules folder. This behavior leads to runtime errors if any of
    the project dependencies requires a different version of a package
    than the project itself.
    
    For example, if we have a project that depends on `express` in version
    `4.17.3` (which on the other hand depends on `path-to-regexp` version
    `0.1.7`) as well as on `path-to-regexp` in version `6.2.0`. In such
    case `express` will throw a runtime error since it would load
    `path-to-regexp` version `6.2.0` which is not API compatible.
    
    For this reason, this commit changes the behavior of the node-executor
    so that it completely ignores npm dependencies when calculating
    resolve mappings.
    hellivan committed Mar 11, 2022
    Copy the full SHA
    5cc29a2 View commit details
    Browse the repository at this point in the history