Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): fix inconsistent tsconfig module casing #9320

Merged
merged 1 commit into from Mar 14, 2022
Merged

fix(js): fix inconsistent tsconfig module casing #9320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/js/src/generators/library/files/lib/tsconfig.json__tmpl__
View file
Open in desktop
@@ -1,7 +1,7 @@
{
"extends": "<%= rootTsConfigPath %>",
"compilerOptions": {
"module": "CommonJS"<% if (js) { %>,
"module": "commonjs"<% if (js) { %>,
"allowJs": true<% } %>
},
"files": [],
Expand Down
2 changes: 1 addition & 1 deletion packages/js/src/generators/library/library.spec.ts
View file
Open in desktop
Expand Up @@ -140,7 +140,7 @@ describe('lib', () => {
Object {
"compilerOptions": Object {
"forceConsistentCasingInFileNames": true,
"module": "CommonJS",
"module": "commonjs",
"noFallthroughCasesInSwitch": true,
"noImplicitOverride": true,
"noImplicitReturns": true,
Expand Down
6 changes: 3 additions & 3 deletions packages/nest/src/generators/library/__snapshots__/library.spec.ts.snap
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ exports[`lib --testEnvironment should set target jest testEnvironment to node by
exports[`lib --unit-test-runner none should not generate test configuration 1`] = `
Object {
"compilerOptions": Object {
"module": "CommonJS",
"module": "commonjs",
},
"extends": "../../tsconfig.base.json",
"files": Array [],
Expand Down Expand Up @@ -70,7 +70,7 @@ Object {
exports[`lib nested should create a local tsconfig.json 1`] = `
Object {
"compilerOptions": Object {
"module": "CommonJS",
"module": "commonjs",
},
"extends": "../../../tsconfig.base.json",
"files": Array [],
Expand Down Expand Up @@ -102,7 +102,7 @@ export class MyLibModule {}
exports[`lib not nested should create a local tsconfig.json 1`] = `
Object {
"compilerOptions": Object {
"module": "CommonJS",
"module": "commonjs",
},
"extends": "../../tsconfig.base.json",
"files": Array [],
Expand Down