fix(core): don't allow arbitrary code execution when manipulating cache #9329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/J4Mobp9MTRHPaqz8xK9m74pwpjCJ [Deployment for 25b9f27 canceled] |
The Node documentation for `exec` states: > Never pass unsanitized user input to this function. Any input containing shell metacharacters may be used to trigger arbitrary command execution. The `folder` variable comes directly from the `NX_CACHE_DIRECTORY` environment variable (or from `nx.json`). Careful crafting of this variable can result in NX executing arbitrary commands. This patch fixes this by using `execFile`, which does not spawn a shell.
AgentEnder
force-pushed
the
fix-task-runner-cache-shell-commands
branch
from
4ab065c
to
25b9f27
Compare
AgentEnder
approved these changes
Mar 15, 2022
FrozenPandaz
approved these changes
Mar 18, 2022
|
Thank you for your contribution! LGTM 🎉 |
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 21, 2022
…he (#9329) The Node documentation for `exec` states: > Never pass unsanitized user input to this function. Any input containing shell metacharacters may be used to trigger arbitrary command execution. The `folder` variable comes directly from the `NX_CACHE_DIRECTORY` environment variable (or from `nx.json`). Careful crafting of this variable can result in NX executing arbitrary commands. This patch fixes this by using `execFile`, which does not spawn a shell.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
A carefully crafted
NX_CACHE_DIRECTORY(environment variable) can make NX execute arbitrary commands. The same holds true for thecacheDirectoryfield innx.json.Expected Behavior
NX should not execute arbitrary code embedded in the
NX_CACHE_DIRECTORYenvironment variable.Fix
The Node documentation for
execstates:The
foldervariable comes directly from theNX_CACHE_DIRECTORYenvironment variable (or fromnx.json). Careful crafting of this variable can result in NX executing arbitrary commands.This patch fixes this by using
execFile, which does not spawn a shell.