Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix missing versions from nx report #9450

Merged
merged 1 commit into from Mar 23, 2022
Merged

fix(core): fix missing versions from nx report #9450

merged 1 commit into from Mar 23, 2022

Conversation

meeroslav
Copy link
Contributor

The report is broken due to double try...catch blocks in readPackageJson and readPackageVersion causing missing packages to show as undefined:

nx : 13.9.4
@nrwl/angular : undefined
@nrwl/cypress : 13.9.4
@nrwl/detox : undefined
@nrwl/devkit : 13.9.4
@nrwl/eslint-plugin-nx : 13.9.4
@nrwl/express : undefined
@nrwl/jest : 13.9.4
@nrwl/js : 13.9.4
@nrwl/linter : 13.9.4
@nrwl/nest : undefined
@nrwl/next : undefined
@nrwl/node : undefined
@nrwl/nx-cloud : 13.1.6
@nrwl/nx-plugin : undefined
@nrwl/react : undefined
@nrwl/react-native : undefined
@nrwl/schematics : undefined
@nrwl/storybook : undefined
@nrwl/web : 13.9.4
@nrwl/workspace : 13.9.4
typescript : 4.5.5
rxjs : 6.5.5

The proper functionality exists (showing Not Found) but is never reached.

Current Behavior

The report shows undefined for missing packages

Expected Behavior

The report shows Not Found for missing packages

Related Issue(s)

Fixes #

@meeroslav meeroslav added the scope: core core nx functionality label Mar 22, 2022
@meeroslav meeroslav self-assigned this Mar 22, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 22, 2022 •
edited

☁️ Nx Cloud Report

CI ran the following commands for commit f797624. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 21 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 22, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/2kd13PVRhvGTUE8cjSjNjzrHEJpP
✅ Preview: Canceled

[Deployment for f797624 canceled]

@AgentEnder AgentEnder merged commit c7e621f into nrwl:master Mar 23, 2022
FrozenPandaz pushed a commit that referenced this pull request Mar 25, 2022
@meeroslav @FrozenPandaz
fix(core): fix missing versions from nx report (#9450)
f5e40ed
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@meeroslav @sidmonta
fix(core): fix missing versions from nx report (nrwl#9450)
cecc1ca
@meeroslav meeroslav deleted the fix/report branch November 8, 2022 15:33
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

Assignees

@meeroslav meeroslav

Labels
scope: core core nx functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meeroslav @AgentEnder