fix(node): allow use multiple config in custom webpack configuration file #9458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guration file When use a custom configuration file for webpack build target allow to run webpack with multiple configuration options. ISSUES CLOSED: nrwl#9186
…file When use a custom configuration file for node webpack build target. allow running webpack with multiple configuration options ISSUES CLOSED: nrwl#9453
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 665df06. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/EEThfjTzuD1oycX85xB16up2kSS3 [Deployment for 665df06 canceled] |
|
Hi @everops-kalarrs, thanks for the heads up. I saw your pull request and maybe I missed something, but I don't see any functional conflicts. The only change I made in the part that you also changed concerns the specification of the Config type which in both cases remains the same. So definitely we can combine the changes, it should be enough either on my end to remove the specification or on your end to add it. If I missed something, sorry, and report it to me without any problem. |
* fix(js): add swc/helpers to js packages on converting to swc * chore(js): update convert to swc unit test * chore(js): format Co-authored-by: Chau Tran <ctran@Chaus-MacBook-Pro.local>
…ious implementation (nrwl#9470)
* feat(dep-graph): add dark mode Squashed commits: feat(dep-graph): Updating tailwind config file. As of version 3.0 higher tailwind jit mode is default. Instead of purge is now content and as dark mode will be added as class. feat(dep-graph): Enabling toggable dark mode. As darkmode (tailwind.congig.json) is set as class, we need to add the script to the head tag on index.html. see: https://tailwindcss.com/docs/dark-mode feat(dep-graph): Adding theme Initializer and creating support functions All functions related to theme changing and initialization are located on the theme-resolver.tsx The themeInit function will run when page is loaded and apply add class to the <html> tag as dark or light accordignly. Theme resolver applies the changes and keeps localstorage and <html class> in sync. feat(dep-graph): Adding theme panel The pannel allows users to switch themes. Currently it only changes the html class and localstorage. feat(dep-graph): Creating tailwind dark colors pallete The current colors remain as light. The dark colors are an attempt to contrast the light ones. feat(dep-graph): Adding additional styles to sidebar feat(dep-graph): Define styling presets for darkmode to allow consistent and concise classNames. feat(dep-graph): Apply dark styling classes to sidebar feat(dep-graph): Added dark mode styles to the debugger feat(dep-graph): Added Color to tailwind config and adjusting imports. feat(dep-graph): Created theme tracker feat(dep-graph): Added dark classes to graph container feat(dep-graph): Adjusted some edge styles for better UX. Added dynamic selection of colors according to the current theme. feat(dep-graph): Added transition when switching themes. feat(dep-graph): Readded auto roation for implicit label and dynamic background. feat(dep-graph): Assigned generic types to selectDynbamically, and added new color to the pallete. feat(dep-graph): Added dynamic styles for theming. feat(dep-graph): Added mock for matchMedia. Tests will fail otherwise. feat(dep-graph): Added styles to tippy. feat(dep-graph): Moved theme related functions to theme-resolver file feat(dep-graph): Implement dark mode on tooltips. feat(dep-graph): re-evaluate graph colors on theme change cleanup(dep-graph): Removed duplicate style chore(dep-graph): Testing theme preferences Adding test cases for theme initialization, and the ability to change. cleanup(dep-graph): removing repeated style classes Fixed issue with webpack plugin (nrwl#8231) feat(npm): resolved issue with live reload failing Fixed the issue with live reload when adding scripts in project.json Closes nrwl#8230 chore(repo): update nx to 13.10.0-beta.1 (nrwl#9407) feat(dep-graph): re-evaluate graph colors on theme change fix(dep-graph): use theme background color in image download * fix(dep-graph): change dark mode styles * cleanup(dep-graph): cleanup e2e tests and naming Co-authored-by: Philip Fulcher <philip@nrwl.io>
…e aligned with new nx workspaces (nrwl#9630)
… projects when keeping the angular cli layout (nrwl#9649)
* chore(core): use optional chaining * chore(core): chore(core): chore(core): use optional chaining * chore(core): use optional chaining * feat(core): chore(core): chore(core): use optional chaining * chore(core): chore(core): use optional chaining * chore(core): chore(core): chore(core): use optional chaining * chore(core): chore(core): use optional chaining * chore(core): chore(core): use optional chaining
* cleanup(misc): replace deprecated String.prototype.substr() .substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com> * fix(js): fix slice change Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
|
@sidmonta I think something's up with this PR. It shouldn't be 1000+ files changed should it? |
|
Hi @nartc, you're right, I messed up by not making a separate branch. I close this pull request and open another one with only my changes. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use a custom configuration file for node webpack build target.
Allow running webpack with multiple configuration options.
Current Behavior
Assigning a custom webpack configuration file does not support the ability to use multiple configurations, as webpack allows.
Expected Behavior
Being able to define multiple configurations in my custom webpack.config.ts file to feed to webpack
Related Issue(s)
Fixes #9453