Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(core): remove the indirection left after inlining ta… #9469

Merged
merged 2 commits into from Mar 24, 2022

Conversation

vsavkin
Copy link
Member

@vsavkin vsavkin commented Mar 22, 2022

…o into nx

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Mar 22, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit b0c98c3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 20 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/4Jb2D5TMxj89QAy3ibD7nrpbmLoU
✅ Preview: https://nx-dev-git-fork-vsavkin-move-cli-code-to-nx-nrwl.vercel.app

@vsavkin vsavkin changed the title cleanup(core): remove the level of indirection left after inlining ta… cleanup(core): remove the indirection left after inlining ta… Mar 22, 2022
@vsavkin vsavkin force-pushed the move-cli-code-to-nx branch 2 times, most recently from c785c6b to 2de4ba1 Compare March 23, 2022 16:40
config?.tasksRunnerOptions['default'].runner ==
'@nrwl/workspace/tasks-runner/default'
) {
config.tasksRunnerOptions['default'].runner = 'nx/tasks-runner/default';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsavkin migration to 13.10 fails
https://github.com/nrwl/nx/tree/master/packages/nx/tasks-runners

Suggested change
config.tasksRunnerOptions['default'].runner = 'nx/tasks-runner/default';
config.tasksRunnerOptions['default'].runner = 'nx/tasks-runners/default';

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #9778

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants