Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-native): change openURLInBrowser to Linking.openURL for rea… #9482

Merged
merged 1 commit into from Apr 3, 2022
+9 −11
Merged

fix(react-native): change openURLInBrowser to Linking.openURL for rea… #9482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 9 additions & 11 deletions packages/react-native/src/generators/application/files/app/src/app/App.tsx.template
View file
Open in desktop
Expand Up @@ -8,11 +8,9 @@ import {
Text,
StatusBar,
TouchableOpacity,
Linking,
} from 'react-native';

// @ts-ignore
import openURLInBrowser from 'react-native/Libraries/Core/Devtools/openURLInBrowser';

import Checkmark from './icons/checkmark.svg';
import Book from './icons/book.svg';
import ChevronRight from './icons/chevron-right.svg';
Expand Down Expand Up @@ -82,7 +80,7 @@ export const App = () => {
<TouchableOpacity
style={[styles.listItem, styles.learning]}
onPress={() =>
openURLInBrowser(
Linking.openURL(
'https://nx.dev/getting-started/intro?utm_source=nx-project'
)
}
Expand All @@ -99,7 +97,7 @@ export const App = () => {
<TouchableOpacity
style={[styles.listItem, styles.learning]}
onPress={() =>
openURLInBrowser(
Linking.openURL(
'https://blog.nrwl.io/?utm_source=nx-project'
)
}
Expand All @@ -116,7 +114,7 @@ export const App = () => {
<TouchableOpacity
style={[styles.listItem, styles.learning]}
onPress={() =>
openURLInBrowser(
Linking.openURL(
'https://www.youtube.com/c/Nrwl_io/videos?utm_source=nx-project'
)
}
Expand All @@ -133,7 +131,7 @@ export const App = () => {
<TouchableOpacity
style={[styles.listItem, styles.learning]}
onPress={() =>
openURLInBrowser(
Linking.openURL(
'https://nx.dev/tutorial/01-create-application?utm_source=nx-project'
)
}
Expand All @@ -150,7 +148,7 @@ export const App = () => {
<TouchableOpacity
style={[styles.listItem, styles.learning]}
onPress={() =>
openURLInBrowser(
Linking.openURL(
'https://nxplaybook.com/?utm_source=nx-project'
)
}
Expand All @@ -169,7 +167,7 @@ export const App = () => {
<View style={styles.section}>
<TouchableOpacity
onPress={() =>
openURLInBrowser(
Linking.openURL(
'https://marketplace.visualstudio.com/items?itemName=nrwl.angular-console&utm_source=nx-project'
)
}
Expand All @@ -196,7 +194,7 @@ export const App = () => {
<View style={styles.section}>
<TouchableOpacity
onPress={() =>
openURLInBrowser('https://nx.app/?utm_source=nx-project')
Linking.openURL('https://nx.app/?utm_source=nx-project')
}
>
<View style={styles.shadowBox}>
Expand Down Expand Up @@ -226,7 +224,7 @@ export const App = () => {
<View style={styles.section}>
<TouchableOpacity
onPress={() =>
openURLInBrowser('https://nx.app/?utm_source=nx-project')
Linking.openURL('https://nx.app/?utm_source=nx-project')
}
>
<View style={[styles.listItem, styles.shadowBox]}>
Expand Down