Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): import builder from core-server, not core #9562

Merged
merged 1 commit into from Mar 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Expand Up @@ -71,7 +71,6 @@
"@nrwl/react": "13.10.0-beta.6",
"@nrwl/web": "13.10.0-beta.6",
"@nrwl/workspace": "13.10.0-beta.6",
"nx": "13.10.0-beta.6",
"@parcel/watcher": "2.0.4",
"@phenomnomnominal/tsquery": "4.1.1",
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.1",
Expand All @@ -87,10 +86,11 @@
"@storybook/addon-knobs": "~6.3.0",
"@storybook/angular": "~6.4.12",
"@storybook/core": "~6.4.12",
"@storybook/core-server": "^6.4.19",
"@storybook/react": "~6.4.12",
"@svgr/webpack": "^6.1.2",
"@swc/core": "^1.2.152",
"@swc-node/register": "^1.4.2",
"@swc/core": "^1.2.152",
"@testing-library/react": "11.2.6",
"@testing-library/react-hooks": "7.0.1",
"@tippyjs/react": "^4.2.6",
Expand Down Expand Up @@ -192,6 +192,7 @@
"ng-packagr": "~13.3.0",
"ngrx-store-freeze": "0.2.4",
"node-fetch": "^2.6.7",
"nx": "13.10.0-beta.6",
"open": "^8.4.0",
"parse-markdown-links": "^1.0.4",
"parse5": "4.0.0",
Expand Down Expand Up @@ -309,4 +310,3 @@
"immer": "~9.0.6"
}
}

9 changes: 9 additions & 0 deletions packages/storybook/migrations.json
Expand Up @@ -81,6 +81,15 @@
}
},
"packageJsonUpdates": {
"13.10.0": {
"version": "13.10.0-beta.0",
"packages": {
"@storybook/core-server": {
"version": "~6.4.12",
"alwaysAddToPackageJson": true
}
}
},
"13.4.5": {
"version": "13.4.5-beta.1",
"packages": {
Expand Down
Expand Up @@ -3,10 +3,10 @@ import * as fs from 'fs';

import { ExecutorContext } from '@nrwl/devkit';

jest.mock('@storybook/core/server', () => ({
jest.mock('@storybook/core-server', () => ({
buildDevStandalone: jest.fn().mockImplementation(() => Promise.resolve()),
}));
import { buildDevStandalone } from '@storybook/core/server';
import { buildDevStandalone } from '@storybook/core-server';

import storybookExecutor, { StorybookExecutorOptions } from './storybook.impl';
import { join } from 'path';
Expand Down
@@ -1,5 +1,5 @@
import { ExecutorContext, logger } from '@nrwl/devkit';
import { buildDevStandalone } from '@storybook/core/server';
import { buildDevStandalone } from '@storybook/core-server';
import 'dotenv/config';
import { showStorybookV5Warning } from '../../utils/utilities';
import { CommonNxStorybookConfig } from '../models';
Expand Down
Expand Up @@ -11,6 +11,7 @@ Object {
"@storybook/addon-essentials": "~6.4.12",
"@storybook/angular": "~6.4.12",
"@storybook/builder-webpack5": "~6.4.12",
"@storybook/core-server": "~6.4.12",
"@storybook/manager-webpack5": "~6.4.12",
"existing": "1.0.0",
"webpack": "^5.64.0",
Expand Down
3 changes: 3 additions & 0 deletions packages/storybook/src/generators/init/init.spec.ts
Expand Up @@ -40,6 +40,9 @@ describe('@nrwl/storybook:init', () => {
expect(
packageJson.devDependencies['@storybook/addon-essentials']
).toBeDefined();
expect(
packageJson.devDependencies['@storybook/core-server']
).toBeDefined();

// angular specific
expect(packageJson.devDependencies['@storybook/angular']).toBeDefined();
Expand Down
7 changes: 7 additions & 0 deletions packages/storybook/src/generators/init/init.ts
Expand Up @@ -37,6 +37,13 @@ function checkDependenciesInstalled(host: Tree, schema: Schema) {
* Leave it alone.
*/

if (
!packageJson.dependencies['@storybook/core-server'] &&
!packageJson.devDependencies['@storybook/core-server']
) {
devDependencies['@storybook/core-server'] = storybookVersion;
}

if (
!packageJson.dependencies['@storybook/addon-essentials'] &&
!packageJson.devDependencies['@storybook/addon-essentials']
Expand Down
1 change: 1 addition & 0 deletions scripts/depcheck/missing.ts
Expand Up @@ -87,6 +87,7 @@ const IGNORE_MATCHES = {
'@storybook/addon-knobs',
'@storybook/addon-essentials',
'@storybook/core',
'@storybook/core-server',
'rxjs',
],
nx: [
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Expand Up @@ -3803,7 +3803,7 @@
dependencies:
core-js "^3.8.2"

"@storybook/core-server@6.4.19":
"@storybook/core-server@6.4.19", "@storybook/core-server@^6.4.19":
version "6.4.19"
resolved "https://registry.yarnpkg.com/@storybook/core-server/-/core-server-6.4.19.tgz#0d1b4b2094749b8bce03e3d01422e14e5fef8e66"
integrity sha512-bKsUB9f7hl5ya2JXxpIrErmbDQjoH39FVbzYZWjMo4t/b7+Xyi6vYadwyWcqlpUQmis09ZaSMv8L/Tw0TuwLAA==
Expand Down