Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): restore failed project summary data to dynamic output #9632

Merged
merged 1 commit into from Mar 31, 2022
Merged

fix(core): restore failed project summary data to dynamic output #9632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
69 changes: 46 additions & 23 deletions packages/nx/src/tasks-runner/life-cycles/dynamic-run-many-terminal-output-life-cycle.ts
View file
Open in desktop
Expand Up @@ -66,6 +66,7 @@ export async function createRunManyDynamicOutputRenderer({
};
});

const failedTasks = new Set();
const tasksToTerminalOutputs: Record<string, string> = {};
const tasksToProcessStartTimes: Record<
string,
Expand Down Expand Up @@ -231,14 +232,6 @@ export async function createRunManyDynamicOutputRenderer({
additionalFooterRows.push('');
}

if (totalFailedTasks > 0) {
additionalFooterRows.push(
` ${output.colors.red(
figures.cross
)} ${totalFailedTasks}${`/${totalCompletedTasks}`} failed`
);
}

if (totalSuccessfulTasks > 0) {
additionalFooterRows.push(
` ${output.colors.green(
Expand All @@ -249,6 +242,14 @@ export async function createRunManyDynamicOutputRenderer({
);
}

if (totalFailedTasks > 0) {
additionalFooterRows.push(
` ${output.colors.red(
figures.cross
)} ${totalFailedTasks}${`/${totalCompletedTasks}`} failed`
);
}

clearPinnedFooter();

if (additionalFooterRows.length > 1) {
Expand Down Expand Up @@ -376,25 +377,46 @@ export async function createRunManyDynamicOutputRenderer({
.forEach((arg) => taskOverridesRows.push(arg));
}

renderPinnedFooter(
[
output.applyNxPrefix(
'red',
output.colors.red(text) + output.dim.white(` (${timeTakenText})`)
),
...taskOverridesRows,
'',
` ${output.colors.red(
figures.cross
)} ${totalFailedTasks}${`/${totalCompletedTasks}`} failed`,
const numFailedToPrint = 5;
const failedTasksForPrinting = Array.from(failedTasks).slice(
0,
numFailedToPrint
);
const failureSummaryRows = [
output.applyNxPrefix(
'red',
output.colors.red(text) + output.dim.white(` (${timeTakenText})`)
),
...taskOverridesRows,
'',
output.dim(
` ${output.dim(
figures.tick
)} ${totalSuccessfulTasks}${`/${totalCompletedTasks}`} succeeded ${output.dim(
`[${totalCachedTasks} read from cache]`
)}`,
],
'red'
);
)}`
),
'',
` ${output.colors.red(
figures.cross
)} ${totalFailedTasks}${`/${totalCompletedTasks}`} targets failed, including the following:`,
`${failedTasksForPrinting
.map(
(t) =>
` ${output.colors.red('-')} ${output.dim('nx run')} ${t}`
)
.join('\n ')}`,
];

if (failedTasks.size > numFailedToPrint) {
failureSummaryRows.push(
output.dim(
` ...and ${failedTasks.size - numFailedToPrint} more...`
)
);
}

renderPinnedFooter(failureSummaryRows, 'red');
}
resolveRenderIsDonePromise();
};
Expand Down Expand Up @@ -443,6 +465,7 @@ export async function createRunManyDynamicOutputRenderer({
break;
case 'failure':
totalFailedTasks++;
failedTasks.add(t.task.id);
break;
}
printTaskResult(t.task, t.status);
Expand Down