Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): remove implicit deps creation from mfe #9799

Merged
merged 1 commit into from Apr 12, 2022
Merged

fix(angular): remove implicit deps creation from mfe #9799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 0 additions & 23 deletions packages/angular/src/generators/setup-mfe/lib/add-implicit-deps.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/angular/src/generators/setup-mfe/lib/index.ts
View file
Open in desktop
@@ -1,6 +1,5 @@
export * from './add-cypress-workaround';
export * from './add-entry-module';
export * from './add-implicit-deps';
export * from './add-remote-to-host';
export * from './change-build-target';
export * from './fix-bootstrap';
Expand Down
16 changes: 0 additions & 16 deletions packages/angular/src/generators/setup-mfe/setup-mfe.spec.ts
View file
Open in desktop
Expand Up @@ -135,22 +135,6 @@ describe('Init MFE', () => {

expect(mfeConfigContents).toContain(`'remote1'`);
});
it('should update the implicit dependencies of the host when --remotes flag supplied', async () => {
// ACT
await setupMfe(tree, {
appName: 'app1',
mfeType: 'host',
remotes: ['remote1'],
});

// ASSERT
const projectConfig: ProjectConfiguration = readProjectConfiguration(
tree,
'app1'
);

expect(projectConfig.implicitDependencies).toContain('remote1');
});

it('should add a remote application and add it to a specified host applications webpack config when no other remote has been added to it', async () => {
// ARRANGE
Expand Down
2 changes: 0 additions & 2 deletions packages/angular/src/generators/setup-mfe/setup-mfe.ts
View file
Open in desktop
Expand Up @@ -6,7 +6,6 @@ import { readProjectConfiguration, formatFiles } from '@nrwl/devkit';
import {
addCypressOnErrorWorkaround,
addEntryModule,
addImplicitDeps,
addRemoteToHost,
changeBuildTarget,
fixBootstrap,
Expand All @@ -30,7 +29,6 @@ export async function setupMfe(tree: Tree, options: Schema) {
generateWebpackConfig(tree, options, projectConfig.root, remotesWithPorts);

addEntryModule(tree, options, projectConfig.root);
addImplicitDeps(tree, options);
changeBuildTarget(tree, options);
updateTsConfigTarget(tree, options);
setupServeTarget(tree, options);
Expand Down