Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): prompt users to connect to nx cloud when upgrading major versions #9849

Conversation

AgentEnder
Copy link
Member

When upgrading between major versions, users should be prompted to connect to nx cloud.

@nx-cloud
Copy link

nx-cloud bot commented Apr 14, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6fc9776. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 13 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/GZjr79m4bHcuP7riXjX3g2JVBv6B
✅ Preview: Ignored

[Deployment for 6fc9776 canceled]

opts.targetVersion
))
) {
await connectToNxCloudCommand(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this instead:

We noticed you are migrating to a new major version, but are not taking advantage of Nx Cloud. Nx Cloud can make your CI up to 10 times faster. Learn more about it here: https://nx.app. Would you like to add it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds good. I'll change it out.

@vsavkin
Copy link
Member

vsavkin commented Apr 14, 2022

Left a comment. Looks good.

@AgentEnder AgentEnder force-pushed the feat/prompt-to-connect-to-nx-cloud-on-major-versions branch from 690b9b0 to 6fc9776 Compare April 14, 2022 19:50
@AgentEnder AgentEnder merged commit a162bfb into nrwl:master Apr 14, 2022
@AgentEnder AgentEnder deleted the feat/prompt-to-connect-to-nx-cloud-on-major-versions branch April 14, 2022 21:17
@fbartho
Copy link

fbartho commented May 9, 2022

This PR introduced the issue seen in #10144 -- comments were made on the specific lines in the commit

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants