Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(core): local plugins should resolve in package-manager wo… #9955

Merged
merged 1 commit into from Apr 22, 2022

Conversation

FrozenPandaz
Copy link
Collaborator

…rkspaces (#9913)"

This reverts commit 2d2c8a7.

Current Behavior

Using Local plugins is not working properly for @nrwl/js, @nrwl/web.

Expected Behavior

@nrwl/js and @nrwl/web won't use the local code.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Apr 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0bb0f2c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 13 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Apr 22, 2022 at 4:49PM (UTC)

@FrozenPandaz FrozenPandaz merged commit 14d9e69 into nrwl:master Apr 22, 2022
@AndyClausen
Copy link
Contributor

Shouldn't this reopen the issues that #9116 had fixed? Or has this been implemented in another way?

@AgentEnder
Copy link
Member

This doesn't revert the local plugin functionality, only the change in resolution to support workspaces created with the core preset

@AgentEnder
Copy link
Member

The issues closed by the PR for that, should be reopened. I've just done so, for the singular issue. #9823

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants