Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): updated dependency fs-extra to ^10.1.0 #9985

Merged
merged 1 commit into from May 6, 2022

Conversation

Phillip9587
Copy link
Contributor

Current Behavior

Nx uses fs-extra ^9.1.0

Expected Behavior

Nx uses fs-extra ^10.1.0

Related Issue(s)

#8531

@nx-cloud
Copy link

nx-cloud bot commented Apr 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 56f9f42. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 6, 2022 at 9:21PM (UTC)

@Phillip9587

This comment was marked as outdated.

@Phillip9587
Copy link
Contributor Author

@FrozenPandaz You already approved this changes in #8531. The reason for the test failures was fixed in fs-extra 10.1.0.

@FrozenPandaz FrozenPandaz self-assigned this Apr 29, 2022
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, glad they fixed it!

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 0cc7042 into nrwl:master May 6, 2022
@Phillip9587 Phillip9587 deleted the fs-extra-10-1-0 branch May 6, 2022 21:57
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants