Fixes for sparse configs #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow unknown country IPs to continue being processed - fix default allows for the privateIP functionality to work
nscuro
requested changes
May 9, 2024
Comment on lines
-172
to
-175
| if country == "-" { | ||
| return p.allowPrivate, country, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
With this check removed, the AllowPrivate option is no longer used anywhere.
Is the intention to have its behavior replaces with DefaultAllow? In that case, could you please remove AllowPrivate from the code, and also from the configuration sample in the README?
traefik-plugin-geoblock/README.md
Lines 56 to 57 in 8542be3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a couple fixes for some configuration edge cases which I somehow failed to get included in the previous PR.