Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yamlfmt instead of prettier to format YAML #568

Merged
merged 1 commit into from
May 13, 2024

Conversation

chuckwondo
Copy link
Collaborator

@chuckwondo chuckwondo commented May 12, 2024

Fixes #555


📚 Documentation preview 📚: https://earthaccess--568.org.readthedocs.build/en/568/

@chuckwondo chuckwondo requested a review from mfisher87 May 12, 2024 16:22
mfisher87
mfisher87 previously approved these changes May 12, 2024
enhanced static type hints for functions and methods that make CMR queries
or handle CMR query results.
* [#421](https://github.com/nsidc/earthaccess/issues/421): Enabled queries to
Earthdata User Acceptance Testing (UAT) system for authenticated accounts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 thank you ✨

I wonder if there's a changelog linting tool that can help us enforce a standard like the one you're setting here.

mkdocs.yml Outdated Show resolved Hide resolved
@mfisher87
Copy link
Member

Integration test failures look ignorable. They're happening everywhere, and this PR doesn't touch anything that could affect runtime.

@chuckwondo
Copy link
Collaborator Author

Integration test failures look ignorable. They're happening everywhere, and this PR doesn't touch anything that could affect runtime.

Weird.

@chuckwondo
Copy link
Collaborator Author

Integration test failures look ignorable. They're happening everywhere, and this PR doesn't touch anything that could affect runtime.

Looks like this was a transient problem. All are passing now.

@chuckwondo chuckwondo requested a review from mfisher87 May 12, 2024 17:24
@mfisher87
Copy link
Member

mfisher87 commented May 12, 2024

There's something bigger going on here maybe. For the last 22 minutes, I was unable to connect to any Google services from my home ISP, but my mobile ISP was fine. Just came back now.

@chuckwondo chuckwondo force-pushed the issue555-pre-commit-yaml-format branch from de672dc to f7af78f Compare May 13, 2024 17:35
@chuckwondo
Copy link
Collaborator Author

@mfisher87, this is ready for your eyes again. I pulled in the additional changelog entry from the other PR that I just merged into main, so the indentation issue you identified is fixed.

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@chuckwondo chuckwondo merged commit 43fd711 into main May 13, 2024
16 checks passed
@chuckwondo chuckwondo deleted the issue555-pre-commit-yaml-format branch May 13, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prettier's pre-commit mirror is archived and keeps trying to upgrade us to alpha version
2 participants