Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [@nteract/web] Migrating local state to global state. #5397

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ramantehlan
Copy link
Member

@ramantehlan ramantehlan commented Dec 6, 2020

This PR is to move the local state values to a global state(redux). It will make it easy to manage and work with the state between different components.

  • Create initial global state.
  • Add reducers and actions for global state values.
  • Integrate global state in different components and pages.
  • I have read the Contributor Guide
  • I have updated the changelogs/current_changelog.md file with some information about the change that I am making the appropriate file.
  • I have validated or unit-tested the changes that I have made.
  • I have run through the TEST_PLAN.md to ensure that my change does not break anything else.

@lgtm-com
Copy link

lgtm-com bot commented Dec 6, 2020

This pull request fixes 3 alerts when merging 5de4f9e into bfc813f - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2020

This pull request fixes 3 alerts when merging 40c6db8 into c585f42 - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2020

This pull request introduces 1 alert and fixes 3 when merging 729d83a into c585f42 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 2 alerts and fixes 7 when merging 6f003e1 into fe90b0a - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

fixed alerts:

  • 6 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 2 alerts and fixes 8 when merging 383a8a2 into fe90b0a - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

fixed alerts:

  • 7 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

@ramantehlan ramantehlan marked this pull request as ready for review February 1, 2021 00:28
@lgtm-com
Copy link

lgtm-com bot commented Feb 1, 2021

This pull request introduces 2 alerts and fixes 8 when merging ffe5835 into 0c8e40f - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

fixed alerts:

  • 7 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

@willingc willingc added the workflow: wip draft work label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
nteract/web & nteract play
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants