Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: Major webpack plugin upgrades for v5 support #75

Merged
merged 2 commits into from
Mar 21, 2021
Merged

Conversation

ntucker
Copy link
Owner

@ntucker ntucker commented Feb 3, 2021

major: css-loader, postcss-loader, html-webpack-plugin, terser-webpack-plugin, webpack-bundle-analyzer, sass-loader
Better support webpack 5

BREAKING CHANGE:

  • drop support for webpack 4
  • remove ~ prefix in sass imports (should still work without it)

Fixes: #52

TODO:

@ntucker ntucker changed the title pkg: css-loader, html-webpack-plugin, terser-webpack-plugin, pkg: Major webpack plugin upgrades for v5 support Feb 3, 2021
@ntucker
Copy link
Owner Author

ntucker commented Feb 4, 2021

Might be able to land this as soon as next week! storybookjs/storybook#9216 (comment) the last piece of the puzzle!

@ntucker ntucker force-pushed the webpack-5 branch 2 times, most recently from 9d544b2 to 8be9a31 Compare February 4, 2021 16:37
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2021

Size Change: -13.8 kB (-3%)

Total Size: 386 kB

Filename Size Change
examples/typescript/dist/App-e82a80ebed802efb62bc.chunk.js 0 B -2.69 kB (removed) 🏆
examples/typescript/dist/App.55d7517032ec2d384629.css 0 B -116 B (removed) 🏆
examples/typescript/dist/Error-index-tsx-6e8a9074dca8ca018d2a.chunk.js 0 B -248 B (removed) 🏆
examples/typescript/dist/fetch-polyfill-90d308347e10c6c7cde1.chunk.js 0 B -2.78 kB (removed) 🏆
examples/typescript/dist/Home-index-tsx-813213b37ed67c41265b.chunk.js 0 B -3.27 kB (removed) 🏆
examples/typescript/dist/Home-index-tsx.c81c71380a5ed7ad950d.css 0 B -115 B (removed) 🏆
examples/typescript/dist/index.html 3.11 kB +487 B (+19%) ⚠️
examples/typescript/dist/intl-polyfill-255f3a2218e74b1d5345.chunk.js 0 B -171 B (removed) 🏆
examples/typescript/dist/Issues-index-tsx-581a0f92dee7cfe402d3.chunk.js 0 B -3.67 kB (removed) 🏆
examples/typescript/dist/locale-en-de5b6761e84de7b395e3.chunk.js 0 B -4.28 kB (removed) 🏆
examples/typescript/dist/my.worker-89c126fd34d7aaaeab0f.worker.js 0 B -579 B (removed) 🏆
examples/typescript/dist/polyfill-231327fe5e29d2a0010b.chunk.js 0 B -4.86 kB (removed) 🏆
examples/typescript/dist/PostDetail-index-tsx-0f6ec4ba9fd542cd6174.chunk.js 0 B -1.74 kB (removed) 🏆
examples/typescript/dist/Posts-index-tsx-31c8f3594f8bbc5ab7d6.chunk.js 0 B -2.19 kB (removed) 🏆
examples/typescript/dist/react-6a1374fff53c4b0cb528.chunk.js 0 B -42.2 kB (removed) 🏆
examples/typescript/dist/router-be3ea6d9d3271ecf952d.chunk.js 0 B -10.3 kB (removed) 🏆
examples/typescript/dist/Slow-index-tsx-cb915161daa2870ec5dd.chunk.js 0 B -427 B (removed) 🏆
examples/typescript/dist/style-9ea8e5d66322b1966a27.chunk.js 0 B -171 B (removed) 🏆
examples/typescript/dist/style.d95f54f273ecb3a429df.css 0 B -522 B (removed) 🏆
examples/typescript/dist/User-index-tsx-cb1ee569d722500f9800.chunk.js 0 B -845 B (removed) 🏆
examples/typescript/dist/vendors~App-70c8689450e6aa30c27f.chunk.js 0 B -57.2 kB (removed) 🏆
examples/typescript/dist/vendors~App.d476927ad5464a3a9b31.css 0 B -67.2 kB (removed) 🏆
examples/typescript/dist/vendors~intl-polyfill-ba79964af91de3aaee3a.chunk.js 0 B -13.6 kB (removed) 🏆
examples/typescript/dist/vendors~Issues-index-tsx-31f9382253f3161afc80.chunk.js 0 B -91.7 kB (removed) 🏆
examples/typescript/dist/vendors~Issues-index-tsx~PostDetail-index-tsx~Posts-index-tsx-a85ea1321b3596fba3a2.chunk.js 0 B -30.2 kB (removed) 🏆
examples/typescript/dist/vendors~Issues-index-tsx~PostDetail-index-tsx~Posts-index-tsx~User-index-tsx-ab57618e9e8d0612cf92.chunk.js 0 B -6.45 kB (removed) 🏆
examples/typescript/dist/vendors~PostDetail-index-tsx~Posts-index-tsx-4db21857addeb7246bd8.chunk.js 0 B -7.47 kB (removed) 🏆
examples/typescript/dist/vendors~PostDetail-index-tsx~User-index-tsx-bed122b73660981f5049.chunk.js 0 B -29.8 kB (removed) 🏆
examples/typescript/dist/vendors~redbox-7f5201e08e3e5730bf07.chunk.js 0 B -10.6 kB (removed) 🏆
examples/typescript/dist/webpack-runtime-9ea5c7f290a1e5035e36.js 0 B -2.07 kB (removed) 🏆
examples/typescript/dist/170-3639d65bcd1df8e535f4.chunk.js 28.9 kB +28.9 kB (new file) 🆕
examples/typescript/dist/433-4c46ff98145ad931c7b4.chunk.js 7.45 kB +7.45 kB (new file) 🆕
examples/typescript/dist/612-1f33363231b9b67e89e9.chunk.js 29.4 kB +29.4 kB (new file) 🆕
examples/typescript/dist/817-3e3ac71764132a20224f.js 53.7 kB +53.7 kB (new file) 🆕
examples/typescript/dist/817.fdfc51c4226dafd03e5f.css 67.2 kB +67.2 kB (new file) 🆕
examples/typescript/dist/842-44d14a5f2c6090ce3fa0.chunk.js 7.32 kB +7.32 kB (new file) 🆕
examples/typescript/dist/857-58eba1934aeed1e07db3.chunk.js 13.6 kB +13.6 kB (new file) 🆕
examples/typescript/dist/997-023efddb37088710bc73.chunk.js 82 kB +82 kB (new file) 🆕
examples/typescript/dist/App-24e723a5d5951a7d9811.js 2.65 kB +2.65 kB (new file) 🆕
examples/typescript/dist/App.078eac21b90767c00e67.css 116 B +116 B (new file) 🆕
examples/typescript/dist/Error-index-tsx-d9854e4f1deb1b484fba.chunk.js 256 B +256 B (new file) 🆕
examples/typescript/dist/fetch-polyfill-67840e0aa73aebb9d0cb.chunk.js 2.8 kB +2.8 kB (new file) 🆕
examples/typescript/dist/Home-index-tsx-6851a6874adc0dada787.chunk.js 3.03 kB +3.03 kB (new file) 🆕
examples/typescript/dist/Home-index-tsx.f4bf6137fe9191e0123d.css 115 B +115 B (new file) 🆕
examples/typescript/dist/intl-polyfill-6898c0c6171955936250.chunk.js 129 B +129 B (new file) 🆕
examples/typescript/dist/Issues-index-tsx-737d9ca9fa4649e1ab8a.chunk.js 3.52 kB +3.52 kB (new file) 🆕
examples/typescript/dist/locale-en-9eb15cb46d189f252de7.chunk.js 4.29 kB +4.29 kB (new file) 🆕
examples/typescript/dist/my.worker-dd331e2e302743098120.worker.js 172 B +172 B (new file) 🆕
examples/typescript/dist/polyfill-524fbf277a2831ae0f53.js 4.73 kB +4.73 kB (new file) 🆕
examples/typescript/dist/PostDetail-index-tsx-8f09a349ee77b102dd77.chunk.js 1.75 kB +1.75 kB (new file) 🆕
examples/typescript/dist/Posts-index-tsx-526ab58d44df7f845523.chunk.js 2.19 kB +2.19 kB (new file) 🆕
examples/typescript/dist/react-001fe1156ae954db66e0.js 42.5 kB +42.5 kB (new file) 🆕
examples/typescript/dist/redbox-e0b9c69bec81c4895c96.chunk.js 10.7 kB +10.7 kB (new file) 🆕
examples/typescript/dist/router-c8c222d133cf3591cc3e.js 10.3 kB +10.3 kB (new file) 🆕
examples/typescript/dist/Slow-index-tsx-dc827ed0c44136f25812.chunk.js 430 B +430 B (new file) 🆕
examples/typescript/dist/style-3abbd6cbb2c7ff84a845.js 129 B +129 B (new file) 🆕
examples/typescript/dist/style.a05d4e219fbdf212c0e9.css 522 B +522 B (new file) 🆕
examples/typescript/dist/User-index-tsx-ea002362a7163011dc8d.chunk.js 844 B +844 B (new file) 🆕
examples/typescript/dist/webpack-runtime-a4f90da27c52c9216cf8.js 2.59 kB +2.59 kB (new file) 🆕

compressed-size-action

…plugin,

webpack-bundle-analyzer, sass-loader major
Better support webpack 5

BREAKING CHANGE:
- drop support for webpack 4
- remove `~` prefix in sass imports (should still work without it)
@ntucker ntucker marked this pull request as ready for review March 21, 2021 07:52
@ntucker ntucker merged commit ff04988 into master Mar 21, 2021
@ntucker ntucker deleted the webpack-5 branch March 21, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 5 warnings
1 participant